Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document IsNoImmediateMethodsObject officially, so that packages are free to use it (it already existed for a long time) #4529

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Document IsNoImmediateMethodsObject officially, so that packages are free to use it (it already existed for a long time) #4529

merged 1 commit into from
Jun 2, 2021

Conversation

ThomasBreuer
Copy link
Contributor

and add a hint to the documentation of vector and matrix objects that setting this filter is recommended for them.
(There is no dedicated "performance hints" section for vector and matrix objects yet.)

@ThomasBreuer
Document IsNoImmediateMethodsObject
6be6920 
and add a hint to the documentation of vector and matrix objects
that setting this filter is recommended for them.
(There is no dedicated "performance hints" section for vector and
matrix objects yet.)
@ThomasBreuer ThomasBreuer added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: documentation Issues and PRs related to documentation release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jun 1, 2021
@ThomasBreuer ThomasBreuer mentioned this pull request Jun 1, 2021
Open
@fingolfin
Copy link
Member

Should this really not be mentioned in the release notes? It might be useful to mention it there to draw attention to it ?

@ThomasBreuer ThomasBreuer changed the title Document IsNoImmediateMethodsObject IsNoImmediateMethodsObject is now a documented filter; it is intended for performance improvements. Jun 2, 2021
@ThomasBreuer ThomasBreuer added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jun 2, 2021
@ThomasBreuer
Copy link
Contributor Author

@fingolfin I have changed the title and the labels according to your suggestion.

@ThomasBreuer ThomasBreuer merged commit 5058a34 into gap-system:master Jun 2, 2021
@ThomasBreuer ThomasBreuer deleted the TB_IsNoImmediateMethodsObject branch June 2, 2021 07:21
@fingolfin fingolfin changed the title IsNoImmediateMethodsObject is now a documented filter; it is intended for performance improvements. Document IsNoImmediateMethodsObject officially, so that packages are free to use it (it already existed for a long time) Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasBreuer @fingolfin